Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor VTI with commander.js #2722

Merged
merged 6 commits into from
Mar 2, 2021
Merged

Refactor VTI with commander.js #2722

merged 6 commits into from
Mar 2, 2021

Conversation

yukukotani
Copy link
Contributor

Resolves #2451.

Refactoring VTI with commander.js.

$ vti --help
Usage: vti [options] [command]

Vetur Terminal Interface

Options:
  -V, --version            output the version number
  -h, --help               display help for command

Commands:
  diagnostics [workspace]  Print all diagnostics
  help [command]           display help for command

  • To follow general CLI design, I replaced vti version with vti --version. Maybe vti version should be remained if we need compatibility.

  • We also should refactor diagnostics.ts but not in the scope for now.

@yukukotani yukukotani mentioned this pull request Feb 25, 2021
Closed
1 task
@yoyo930021
Copy link
Member

Thanks for your PR. I will take a look in the weekend.

yoyo930021
yoyo930021 approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@yoyo930021 yoyo930021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@yoyo930021 yoyo930021 merged commit 7a0a24b into vuejs:master Mar 2, 2021
This was referenced Mar 11, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo930021 yoyo930021 yoyo930021 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor VTI with modern cli library
2 participants
@yukukotani @yoyo930021